Tweak some minor UI issues #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a110605
commented
Jun 6, 2024
| @@ -140,6 +140,12 @@ | |||
| color: white !important; | |||
| } | |||
|
|
|||
| .ant-table-empty{ | |||
There was a problem hiding this comment.
The strange white overlay on the fixed right column. Only happen when table is empty and has fixed: right.
After fix
a110605
commented
Jun 6, 2024
| @@ -18,7 +18,7 @@ const getMenus = function (menuArray, siderFold) { | |||
| <span> | |||
| {item.icon ? <Icon type={item.icon} /> : ''} | |||
| {siderFold && topMenus.indexOf(item.key) >= 0 ? '' : item.name} | |||
| <Icon type="down" /> | |||
| <Icon type="down" style={{ marginLeft: 5 }} /> | |||
a110605
commented
Jun 6, 2024
| </CopyToClipboard> : 'URL no available' | ||
| } | ||
| </p> | ||
| <h3> Backup URL </h3> |
There was a problem hiding this comment.
Get URL dropdown is disabled if url is empty. So I refactor to make this BackupURL modal simple.
a110605
commented
Jun 6, 2024
| @@ -47,7 +47,6 @@ function actions({ selected, showEditDisksModal, deleteHost }) { | |||
| const tooltipProps = { placement: 'left' } | |||
| return ( | |||
| <DropOption | |||
| buttonStyle={{ padding: '0 0' }} | |||
There was a problem hiding this comment.
Fix missing paddings of dropOption
a110605
commented
Jun 6, 2024
| {attchedNodeIsDown ? <Tooltip title={'The attached node is down'}><Icon className="faulted" style={{ transform: 'rotate(45deg)', marginRight: 5 }} type="api" /></Tooltip> : ''} | ||
| {attachedNodeIsDown && ( | ||
| <Tooltip title={'The attached node is down'}> | ||
| <Icon className="faulted" style={{ transform: 'rotate(45deg)', marginRight: 5, marginLeft: 5 }} type="api" /> |
There was a problem hiding this comment.
Add some marginLeft for volume state column Icon
a110605
commented
Jun 6, 2024
| @@ -21,7 +21,7 @@ const modal = ({ | |||
| if (item.podList) { | |||
| CardItem = item.podList.map((ele, index) => { | |||
| return ( | |||
| <div style={{ border: '1px solid #f4f4f4', padding: 24, marginRight: 5, marginBottom: 10 }} key={index}> | |||
| <div style={{ width: '100%', border: '1px solid #f4f4f4', padding: 24, marginRight: 5, marginBottom: 10 }} key={index}> | |||
a110605
commented
Jun 6, 2024
| @@ -28,3 +28,9 @@ | |||
| display: inline-block; | |||
| } | |||
| } | |||
|
|
|||
| :global{ | |||
There was a problem hiding this comment.
Make text align center
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's change in this PR?
Tweak some stange LH UI issues listed in [UI][IMPROVEMENT] Tweak some minor UI issues
Issue
[UI][IMPROVEMENT] Tweak some minor UI issues
Result
See below comments